#20973: Cartan type Aoo
-------------------------------------+-------------------------------------
       Reporter:  andrew.mathas      |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.3
      Component:  combinatorics      |   Resolution:
       Keywords:  Cartan type, A     |    Merged in:
  infinity                           |
        Authors:  Andrew Mathas      |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/andrew.mathas/cartan_type_aoo    |  3c5370673410e49fc0acbff86d1ba443c72a44a8
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by tscrim):

 Also, this sentence is vague:
 {{{
     In sage `oo` is the same as `+Infinity` so `NN` and `ZZ` are used to
     differentiate between the `A_{+\infty}` and `A_{\infty}` root systems.
 }}}
 In particular, what does `oo` do? I would write the entire docstring as:
 {{{#!python
 class CartanType(CartanType_standard, CartanType_simple):
     r"""
     Define the Cartan type `A_{\infty}`.

     We use `NN` and `ZZ` to explicitly differentiate between the
     `A_{+\infty}` and `A_{\infty}` root systems. While `oo` is
     the same as `+Infinity` in Sage, it is used as an alias
     for `ZZ`.
     """
 }}}
 I would also move all of the `EXAMPLES::` from the `__init__` into the
 class-level doc above (but leave the ones in `TESTS::` in `__init__`).

--
Ticket URL: <https://trac.sagemath.org/ticket/20973#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to