#8115: bad patching practice in cddlib-094f.p2.spkg
------------------------+---------------------------------------------------
Reporter: mvngu | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: packages | Keywords: cddlib, polyhedra
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Comment(by vbraun):
New version now has unmodified src (except for deleting unnecessary
subdirectories).
http://www.stp.dias.ie/~vbraun/cddlib-094f.p4.spkg
To simplify review I'll attach spkg-install in verbatim.
Changes:
* libtool-ized, see http://trac.sagemath.org/sage_trac/ticket/3304
After implementing the changes, I found that tabbott proposed a
similar patch to the automake files earlier:
http://sagetrac.org/sage_trac/ticket/3304
* renamed configure.in -> configure.ac (preferred usage)
* renamed patches/cdd_both_reps-makefiles.patch -> patches/automake.patch
* added check for required mpir (aka GMP) to spkg-install
* added spkg-check
* corrected src/patch usage
* removed CFLAGS settings in spkg-install, not required.
* Workaround for spkg-env setting RM="rm"
http://trac.sagemath.org/sage_trac/ticket/7818#comment:28
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8115#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
