#8115: bad patching practice in cddlib-094f.p2.spkg
------------------------------------------+---------------------------------
Reporter: mvngu | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: packages | Keywords: cddlib, polyhedra
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: changes must be checked in |
------------------------------------------+---------------------------------
Changes (by mvngu):
* status: needs_work => needs_review
Comment:
Here's an updated spkg
http://boxen.math.washington.edu/home/mvngu/patch/cddlib-094f.p4.spkg
which commits all outstanding changes in vbraun's name. In this updated
spkg, I inserted the following line in spkg-install:
{{{
[mv...@mod cddlib-094f.p4]$ hg diff
diff -r 499a1b5d0357 spkg-install
--- a/spkg-install
+++ b/spkg-install
@@ -47,6 +47,9 @@
# See http://trac.sagemath.org/sage_trac/ticket/7818#comment:28
unset RM
+# apply patches on top of pristine upstream release under src/
+patch
+
cd src
./configure --prefix=$SAGE_LOCAL
}}}
This runs the function `patch()` in `spkg-install` so that the patching is
done before configuring the upstream source under `src/`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8115#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
