#8115: bad patching practice in cddlib-094f.p2.spkg
------------------------+---------------------------------------------------
Reporter: mvngu | Owner: tbd
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.3.2
Component: packages | Keywords: cddlib, polyhedra
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by mvngu):
* status: needs_review => positive_review
Comment:
Replying to [comment:8 vbraun]:
> I didn't know that I had commit rights to the mercurial repository!
To some extent, any Sage developer has commit rights. The idea is that one
puts one's username in any Mercurial patch. For spkg updates, all changes
need to be checked in before submitting them for review. In this way,
people know who did what and when. As for patches against the Sage
library, a release manager would commit a patch using the username of the
developer who wrote that patch. This process can be made easier if the
developer puts their username on their patch. By username, this is
understood as being a developer's real name, not the username for logging
into the Trac server.
[[BR]][[BR]]
> Here is a fixed spkg:
>
> http://www.stp.dias.ie/~vbraun/cddlib-094f.p4.spkg
>
> Also, changes now checked into hg repo.
The updated spkg looks good. I longer see any binaries being moved to the
script repository at `SAGE_ROOT/local/bin`. All doctests pass.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8115#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
