#8115: bad patching practice in cddlib-094f.p2.spkg
------------------------+---------------------------------------------------
Reporter: mvngu | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: packages | Keywords: cddlib, polyhedra
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by vbraun):
* work_issues: changes must be checked in =>
Comment:
I didn't know that I had commit rights to the mercurial repository! Also,
I thought that the patch function would be called automatically, but
clearly it is not and spkg-install has to call it manually. I did not
catch that error because I did not delete $SAGE_LOCAL/*/cdd* before force-
reinstalling.
Testing the spkg properly, I now noticed that the main src/Makefile.m4 was
not included in patches/, and other Makefile.am's were not copied to the
right place. Here is a fixed spkg:
http://www.stp.dias.ie/~vbraun/cddlib-094f.p4.spkg
Also, changes now checked into hg repo.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8115#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
