#8641: "sage -t" should exit with nonzero exit code if doctests fail
----------------------------------------+-----------------------------------
Reporter: ddrake | Owner: tbd
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.0
Component: doctest | Keywords:
Author: Dan Drake, John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------------------+-----------------------------------
Comment(by ddrake):
Replying to [comment:15 mpatel]:
> Replying to [comment:13 mpatel]:
>
> > By the way, we may need to rebase these for #8891.
>
> I've attached a [attachment:trac_8641-doctest_exit_codes.patch combined,
rebased patch].
Hmm, on 4.4.4.alpha0, I get a hunk reject: on line 123 or so, my copy of
sage-test says
{{{
elif os.path.isdir(F) and not (F[:1] == '.') \
and not '#' in F and not os.sep + 'notes' in F:
}}}
and your patch says
{{{
elif (os.path.isdir(F) and not '#' in F and
not os.sep + 'notes' in F):
}}}
...so somebody changed the backslash line continuation to parentheses.
I'll manually fix the hunk and test your patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8641#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
