#6449: Additive abelian groups
--------------------------------------------+-------------------------------
Reporter: davidloeffler | Owner: joyner
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.5
Component: group_theory | Keywords: abelian group
Author: David Loeffler | Upstream: N/A
Reviewer: John Cremona, Jim Stankewicz | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Changes (by cremona):
* status: positive_review => needs_work
Comment:
Sorry about that. There was only trivial rebasing needed to the first
patch (it fixed some small bugs in mrange, and those had already been
fixed elsewhere, so it was possible to just ignore the failing hunks).
The patch named trac_6449-1a-abgps.patch can therefore replace the one
named trac_6449-1-abgps.patch, followed by -2, -3 and -review. These
apply to 4.5.alpha0 (and probably also to 4.4.4, but my 4.4.4 build is
currently devoted to the pari upgrade). I am currently testing the whole
sage library -- done (see below).
If a single folded patch is still required I should be able to do that,
but applying 4 patches is not as bad as on some tickets (and they are
logically separate).
There is one doctest failure:
{{{
File
"/storage/jec/sage-4.5.alpha0/devel/sage-6449/sage/groups/abelian_gps/abelian_group.py",
line 538:
sage: bool(T) # indirect doctest
Expected:
False
Got:
True
}}}
I suggest changing the code of that one-line function to
{{{
return self.order()>1
}}}
but I don't actually know what is going on there as it's an indirect
doctest!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6449#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
