#6449: Additive abelian groups
--------------------------------------------+-------------------------------
Reporter: davidloeffler | Owner: joyner
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.5
Component: group_theory | Keywords: abelian group
Author: David Loeffler | Upstream: N/A
Reviewer: John Cremona, Jim Stankewicz | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Comment(by davidloeffler):
I made a completely fresh clone. Here's what happened:
{{{
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel$ cd sage-abgp/
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ mysage -hg
qimport http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/6449/trac_6449-1a-abgps.patch
http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/6449/trac_6449-2-homology.patch
http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/6449/trac_6449-3-elliptic.patch
http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/6449/trac_6449-review.patch
http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/6449/trac_6449-doctest_fix.patch
adding trac_6449-1a-abgps.patch to series file
adding trac_6449-2-homology.patch to series file
adding trac_6449-3-elliptic.patch to series file
adding trac_6449-review.patch to series file
adding trac_6449-doctest_fix.patch to series file
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ mysage -hg
qpush
applying trac_6449-1a-abgps.patch
now at: trac_6449-1a-abgps.patch
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ mysage -hg
qpush
applying trac_6449-2-homology.patch
now at: trac_6449-2-homology.patch
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ mysage -hg
qpush
applying trac_6449-3-elliptic.patch
patching file sage/schemes/elliptic_curves/ell_finite_field.py
Hunk #3 FAILED at 1205
Hunk #5 FAILED at 1295
2 out of 6 hunks FAILED -- saving rejects to file
sage/schemes/elliptic_curves/ell_finite_field.py.rej
patching file sage/schemes/elliptic_curves/ell_torsion.py
Hunk #6 succeeded at 102 with fuzz 2 (offset 0 lines).
Hunk #7 succeeded at 149 with fuzz 2 (offset 0 lines).
patching file sage/schemes/elliptic_curves/padics.py
Hunk #2 FAILED at 611
1 out of 2 hunks FAILED -- saving rejects to file
sage/schemes/elliptic_curves/padics.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh trac_6449-3-elliptic.patch
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ find -name
"*.rej" | xargs rm; mysage -hg qrefresh
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ mysage -hg
qpush
applying trac_6449-review.patch
patching file sage/schemes/elliptic_curves/ell_finite_field.py
Hunk #1 FAILED at 1418
Hunk #2 FAILED at 1444
2 out of 2 hunks FAILED -- saving rejects to file
sage/schemes/elliptic_curves/ell_finite_field.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh trac_6449-review.patch
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ find -name
"*.rej" | xargs rm; mysage -hg qrefresh
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ mysage -hg
qpushapplying trac_6449-doctest_fix.patch
now at: trac_6449-doctest_fix.patch
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ find -name
"*.rej" | xargs rm; mysage -hg qrefresh
rm: missing operand
Try `rm --help' for more information.
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$ mysage -b;
mysage -tp 16 sage/schemes/elliptic_curves/
----------------------------------------------------------
sage: Building and installing modified Sage library files.
[snip]
Testing that Sage starts...
Yes, Sage starts.
Global iterations: 1
File iterations: 1
Using cached timings to run longest doctests first.
Doctesting 38 files doing 16 jobs in parallel
sage -t sage/schemes/elliptic_curves/__init__.py
[0.1 s]
sage -t sage/schemes/elliptic_curves/ec_database.py
[2.5 s]
sage -t sage/schemes/elliptic_curves/all.py
[2.7 s]
sage -t sage/schemes/elliptic_curves/cm.py
[2.8 s]
sage -t sage/schemes/elliptic_curves/ell_padic_field.py
[2.9 s]
sage -t sage/schemes/elliptic_curves/ell_local_data.py
[5.8 s]
sage -t sage/schemes/elliptic_curves/ell_wp.py
[3.9 s]
sage -t sage/schemes/elliptic_curves/ell_field.py
[8.8 s]
sage -t sage/schemes/elliptic_curves/descent_two_isogeny.pyx
[9.1 s]
sage -t sage/schemes/elliptic_curves/ell_tate_curve.py
[9.3 s]
sage -t sage/schemes/elliptic_curves/gp_simon.py
[3.8 s]
sage -t sage/schemes/elliptic_curves/ell_torsion.py
[10.5 s]
sage -t sage/schemes/elliptic_curves/gp_cremona.py
[4.9 s]
sage -t sage/schemes/elliptic_curves/gal_reps.py
[7.3 s]
sage -t sage/schemes/elliptic_curves/kodaira_symbol.py
[2.4 s]
sage -t sage/schemes/elliptic_curves/mod5family.py
[2.9 s]
sage -t sage/schemes/elliptic_curves/modular_parametrization.py
[3.6 s]
sage -t sage/schemes/elliptic_curves/monsky_washnitzer.py
[4.0 s]
sage -t sage/schemes/elliptic_curves/padic_height.py
[3.2 s]
sage -t sage/schemes/elliptic_curves/BSD.py
Exception raised by doctesting framework. Use -verbose for details.
[20.7 s]
sage -t sage/schemes/elliptic_curves/lseries_ell.py
[9.0 s]
sage -t sage/schemes/elliptic_curves/sea.py
[2.1 s]
sage -t sage/schemes/elliptic_curves/weierstrass_morphism.py
[3.6 s]
sage -t sage/schemes/elliptic_curves/constructor.py
[29.8 s]
sage -t sage/schemes/elliptic_curves/ell_finite_field.py
**********************************************************************
File "/storage/masiao/sage-4.5.alpha1/devel/sage-
abgp/sage/schemes/elliptic_curves/ell_finite_field.py", line 1421:
sage: E.abelian_group()
Expected:
(Multiplicative Abelian Group isomorphic to C10, ...
Got:
Additive abelian group isomorphic to Z/10 embedded in Abelian group of
points on Elliptic Curve defined by y^2 = x^3 + 2*x + 5 over Finite Field
of size 11
**********************************************************************
File "/storage/masiao/sage-4.5.alpha1/devel/sage-
abgp/sage/schemes/elliptic_curves/ell_finite_field.py", line 1427:
sage: E.abelian_group()
Expected:
(Multiplicative Abelian Group isomorphic to C22 x C2, ...
Got:
Additive abelian group isomorphic to Z/2 + Z/22 embedded in Abelian
group of points on Elliptic Curve defined by y^2 = x^3 + 2*x + 5 over
Finite Field of size 41
**********************************************************************
File "/storage/masiao/sage-4.5.alpha1/devel/sage-
abgp/sage/schemes/elliptic_curves/ell_finite_field.py", line 1434:
sage: E.abelian_group()
Expected:
(Multiplicative Abelian Group isomorphic to C26 x C26, ...
Got:
Additive abelian group isomorphic to Z/26 + Z/26 embedded in Abelian
group of points on Elliptic Curve defined by y^2 = x^3 +
(a^4+a^3+2*a^2+2*a)*x + (2*a^5+2*a^3+2*a^2+1) over Finite Field in a of
size 3^6
**********************************************************************
File "/storage/masiao/sage-4.5.alpha1/devel/sage-
abgp/sage/schemes/elliptic_curves/ell_finite_field.py", line 1441:
sage: E.abelian_group()
Expected:
(Multiplicative Abelian Group isomorphic to C1031352, ...
Got:
Additive abelian group isomorphic to Z/1031352 embedded in Abelian
group of points on Elliptic Curve defined by y^2 = x^3 + (2*a^2+48*a+27)*x
+ (89*a^2+76*a+24) over Finite Field in a of size 101^3
**********************************************************************
File "/storage/masiao/sage-4.5.alpha1/devel/sage-
abgp/sage/schemes/elliptic_curves/ell_finite_field.py", line 1447:
sage: E.abelian_group()
Expected:
(Trivial Abelian Group, ())
Got:
Trivial group embedded in Abelian group of points on Elliptic Curve
defined by y^2 + y = x^3 + x + 1 over Finite Field of size 2
**********************************************************************
1 items had failures:
5 of 24 in __main__.example_24
***Test Failed*** 5 failures.
For whitespace errors, see the file
/home/masiao/.sage//tmp/.doctest_ell_finite_field.py
[34.9 s]
sage -t sage/schemes/elliptic_curves/period_lattice.py
[18.6 s]
sage -t sage/schemes/elliptic_curves/formal_group.py
[33.2 s]
sage -t sage/schemes/elliptic_curves/ell_modular_symbols.py
[39.3 s]
sage -t sage/schemes/elliptic_curves/padics.py
[21.6 s]
sage -t sage/schemes/elliptic_curves/ell_egros.py
[41.1 s]
sage -t sage/schemes/elliptic_curves/ell_curve_isogeny.py
[45.4 s]
sage -t sage/schemes/elliptic_curves/ell_generic.py
[48.5 s]
sage -t sage/schemes/elliptic_curves/ell_point.py
[51.0 s]
sage -t sage/schemes/elliptic_curves/padic_lseries.py
[42.0 s]
sage -t sage/schemes/elliptic_curves/ell_rational_field.py
[62.7 s]
sage -t sage/schemes/elliptic_curves/ell_number_field.py
[67.5 s]
sage -t sage/schemes/elliptic_curves/sha_tate.py
[55.0 s]
sage -t sage/schemes/elliptic_curves/heegner.py
[97.1 s]
----------------------------------------------------------------------
The following tests failed:
sage -t devel/sage-abgp/sage/schemes/elliptic_curves/BSD.py #
Exception from doctest framework
sage -t devel/sage-
abgp/sage/schemes/elliptic_curves/ell_finite_field.py # 5 doctests failed
----------------------------------------------------------------------
Timings have been updated.
Total time for all tests: 109.3 seconds
mas...@selmer:/storage/masiao/sage-4.5.alpha1/devel/sage-abgp$
}}}
The only explanation I can come up with is that this has something to do
with #9127, which was more or less the only non-graph-theory patch merged
in 4.5.alpha1.
David
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6449#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
