#6449: Additive abelian groups
--------------------------------------------+-------------------------------
Reporter: davidloeffler | Owner: joyner
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.5
Component: group_theory | Keywords: abelian group
Author: David Loeffler | Upstream: N/A
Reviewer: John Cremona, Jim Stankewicz | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Changes (by davidloeffler):
* status: positive_review => needs_work
Comment:
I actually made that last patch without the other patches applied :-) So
I've now realised that there is a problem with applying those patches;
whatever I do it won't apply cleanly. If I apply
{{{
trac_6449-1a-abgps.patch
trac_6449-2-homology.patch
trac_6449-3-elliptic.patch
}}}
then I get a bunch of rejects. If I just delete the .rej files and apply
{{{trac_6449-review.patch}}} I get even more rejects, and a whole load of
doctests fail in elliptic curves. I spent a while fixing them -- most were
trivial (although tedious), but one stubborn failure in BSD.py required me
to add half a dozen lines of new code to get the coercion system to behave
itself; this isn't something that can be left to the release manager!
So I urge you to go through your personal patch stack, check that
everything's qrefreshed, qfold the lot, check it applies 100% cleanly and
upload it. (Make sure you don't qpop patches that applied with rejects
without qrefreshing them first, even if you didn't make any changes
yourself before creating/applying the next patch -- you need to qrefresh
so hg knows you've dealt with the rejects. I just made that mistake.)
Alternatively, I can fold and upload what I've got here, and point you to
the minor change I had to make to get BSD.py to pass.
David
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6449#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
