#6449: Additive abelian groups
--------------------------------------------+-------------------------------
Reporter: davidloeffler | Owner: joyner
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.5
Component: group_theory | Keywords: abelian group
Author: David Loeffler | Upstream: N/A
Reviewer: John Cremona, Jim Stankewicz | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Changes (by davidloeffler):
* status: needs_work => needs_review
Comment:
I guess the moral here is that one can't rely on an old outdated patch
always failing in exactly the same way, i.e. the selection of exactly
which hunks apply and which don't seems to be a bit random.
Anyway: another issue here is the danger of conflicts with other
positively-reviewed patches which touch elliptic curves. Right now there
are 13 of these from 11 tickets: 7930, 8680, 9087, 9110, 9266, 9287, 9302,
9313, 9324, 9342 and 9372.
So I downloaded all of these, applied the patches from this ticket
(including the review patch), and cleaned up the mess, and everything was
fine except for one thing: there wasn't a coercion from the torsion
subgroup of an elliptic curve to the full M-W group, and more generally
from an additive abelian group wrapper to its "universe", which causes the
doctest failure in BSD.py reported in my previous message. I added an
UnwrappingMorphism class to additive_abelian_wrapper which does exactly
that. With that change, all doctests seem to pass.
It turns out that the patch thus obtained actually doesn't conflict with
any of the other positively reviewed patches above except #9278, but you
need that one installed. It passes doctests both with and without the
other 10 tickets. If someone could quickly check that the new
UnwrappingMorphism looks plausible, then I think this will finally be
ready to merge.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6449#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
