#9433: Put more files under revision control.
-----------------------------+----------------------------------------------
   Reporter:  jhpalmieri     |       Owner:  tbd         
       Type:  enhancement    |      Status:  needs_review
   Priority:  major          |   Milestone:  sage-4.5.3  
  Component:  distribution   |    Keywords:              
     Author:  John Palmieri  |    Upstream:  N/A         
   Reviewer:                 |      Merged:              
Work_issues:                 |  
-----------------------------+----------------------------------------------
Changes (by jhpalmieri):

  * status:  needs_work => needs_review


Comment:

 Replying to [comment:15 mpatel]:
 > The new 4.5.99 builds successfully from source and passes the long
 doctests.  But `hg log` in the root repo for 4.5.99 lists just revision 0,
 and the root repo is missing from a binary distribution made with `./sage
 -bdist 4.5.99`.

 Right, I didn't do this right.  In the new patch, the root repo is not
 modified at all by sage-make_devel_packages; instead, sage-sdist clones
 it, tags it, and commits the new tag, while sage-bdist just clones it.

 > I also noticed
 >
 >  * SAGE_ROOT/ipython and SAGE_ROOT/sage-README-osx.txt are missing from
 the new source and binary distributions.

 The missing ipython directory was an oversight.  I think I've fixed it.
 The missing sage-README-osx.txt was intentional: this should only be
 included for binary distributions on OS X, and its presence there is taken
 care of by sage-bdist:
 {{{
 if [ "$UNAME" = "Darwin" ]; then
     ...
     cp sage/local/bin/sage-README-osx.txt README.txt
     ...
 }}}
 Perhaps we can close #6938 if this gets merged?

 >  * An extra SAGE_ROOT/sage-python after unpacking sage-4.5.99.tar.

 This was intentional.  Before this, the file sage-python was stored in the
 scripts repo and then unpacked to the top level.  I'm not sure why this
 was done, but I wanted to keep the end result as close as possible to what
 it was before.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9433#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to