#9433: Put more files under revision control.
-----------------------------+----------------------------------------------
Reporter: jhpalmieri | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5.3
Component: distribution | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by kcrisman):
> > I also noticed
> >
> > * SAGE_ROOT/ipython and SAGE_ROOT/sage-README-osx.txt are missing
from the new source and binary distributions.
>
> The missing ipython directory was an oversight. I think I've fixed it.
The missing sage-README-osx.txt was intentional: this should only be
included for binary distributions on OS X, and its presence there is taken
care of by sage-bdist:
> {{{
> if [ "$UNAME" = "Darwin" ]; then
> ...
> cp sage/local/bin/sage-README-osx.txt README.txt
> ...
> }}}
> Perhaps we can close #6938 if this gets merged?
As one of the people involved on that ticket, that is fine. The problem is
that #6938 does not currently have positive review! So I think that would
be necessary first, or something else indicating that the solution
proposed there is correct. Maybe 'merge' that ticket at the same time as
this one, for whatever it's worth.
Sounds like you agree :) In fact, notice that once that is removed, that
file will only appear ABOVE the SAGE_ROOT directory, in the place a normal
README would occur in a dmg or bundle, so it does work properly (I've
tested this numerous times
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9433#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
