#9603: Force iconv to build + install on HP-UX. Currently it is only installed
on
Solaris and Cygwin.
--------------------------------------------+-------------------------------
Reporter: drkirkby | Owner: drkirkby
Type: defect | Status: needs_info
Priority: minor | Milestone: sage-4.5.3
Component: build | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: Peter Jeremy, Leif Leonhardy | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Changes (by drkirkby):
* cc: mpatel (added)
Comment:
Replying to [comment:29 leif]:
> Well, meanwhile iconv was buried rather deep in one of my stacks of
notes...
>
> The latest patch looks quite fine, so my reviewer patch will be fairly
small. :)
Relief!!
> Can you confirm that ''reinstalling'' iconv still works, since you also
dropped ''the code'' that removed the traces of previous iconv
installations?
Yes, it is OK
Although I added the code originally to delete previous parts of the
install, I think it is perhaps not wise. It's simply going to be
impossible to do this accurately all the time. The best we could do it to
get it working for most people most of the time. It might be feasible if a
package only installs a few files, but when many files are installed, and
the installed files will probably change with operating system, it is hard
to do well. I think it's best simply to not try at all. In any case, few
if any other Sage packages do this. I can't think of one in fact.
> Also, can you check if using {{{$MAKE}}} instead of {{{make}}} in both
{{{spkg-install}}} and {{{spkg-check}}} (especially when doing a parallel
build, i.e. with multiple {{{make}}} jobs) would work?
I will do.
> (You haven't [yet] changed that, but we should ''always'' use
{{{$MAKE}}} instead of {{{make}}}, since the user might have set it to
something else, not limited to e.g. {{{"make -j"}}}. As noted above, in
case parallel build/check doesn't work, we should use {{{$MAKE -j1
...}}}.)
I realise this. However, I am well aware that making changes like that are
well outside the scope of the original ticket, and potentially more risky.
If I get a ticket merged with the title '''Force iconv to build + install
on HP-UX. Currently it is only installed on Solaris and Cygwin''' and that
screws up a build on Linux, I am not going to be a very popular person
that is for sure! Enabling parallel builds is easy to do, but difficult to
test thoroughly.
Thankfully, iconv is only installed on Solaris and Cygwin, so hopefully
this wont cause too many guns to be fired at me if it goes wrong! This
ticket has been changed from one that was very safe (adding {{{&& [
"x$UNAME" != xHP-UX ]}}} in a couple of places), into one which has major
changes to the structure, style and possibly the inclusion of parallel
builds. Really I feel those changes should have been on another ticket.
I think I'm going to change the title. And you can be sure I will deflect
some of the blame at you if it goes wrong!!!
I'll check to '''needs review''' once I've tested this.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9603#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
