#9337: Add toric divisors
-------------------------------------------+--------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: algebraic geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: subsequent patch rebasement |
-------------------------------------------+--------------------------------
Changes (by novoselt):
* status: needs_info => needs_work
* work_issues: => subsequent patch rebasement
Comment:
Volker, I have done some more changes to the documentation of the module
itself, `function_value`, and `m`, please check that they are OK. It seems
to me that traditionally support functions are defined for Cartier
divisors only. It is easy to extend the notion to QQ-Cartier divisors, but
do they have any meaning for a general Weil divisor?
I have simplified examples for `is_Weil` etc. and moved your more
complicated version to the module documentation, where it looks very good,
I think, since it shows examples of all divisors which are "X but not Y".
I have defined `_repr_` and `_latex_` for generic divisors to wrap the
defining part of each term in `V(...)`, which does not look that great on
existing examples with ZZ, but I think that `4*V(5)` is still better than
`4*5` and in those cases where something else is desired there should be a
derived class with overridden `_repr_`, while in most case some kind of a
"zero set notation" works great. It is a bit annoying how in LaTeX
presentation negative coefficients are wrapped in parenthesis, but fixing
it the right way requires deeper digging in sage.misc and I'd rather do it
sometime later (or wait until someone else fixes it ;-)).
I have not yet tested this patch against the whole library (doing it now),
if there are way too many doctests to fix, I'll move this functions to
toric divisors only.
The next patch on the ticket does not apply cleanly anymore and needs to
be rebased (after you agree with my patch), sorry!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9337#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
