#9337: Add toric divisors
----------------------------------+-----------------------------------------
   Reporter:  vbraun              |       Owner:  AlexGhitza
       Type:  enhancement         |      Status:  needs_info
   Priority:  major               |   Milestone:  sage-4.6  
  Component:  algebraic geometry  |    Keywords:            
     Author:  Volker Braun        |    Upstream:  N/A       
   Reviewer:  Andrey Novoseltsev  |      Merged:            
Work_issues:                      |  
----------------------------------+-----------------------------------------

Comment(by vbraun):

 `_pairwise_product_` is there so you can multiply elements of the Mori and
 Kahler cone.

   1. That would be the nef cone and please don't rename it to
 `nef_cone`... unless you implement a way to distinguish the rays of an
 open cone from the rays of a closed cone :-P

   3.  I'm against `h(k)` as a synonym for `h_vector()[k]`, this should be
 handled by polymorphism. If you want you can rename `cohomology`->`h`, but
 thats against the usual naming conventions. I am confident that returning
 an integer or integer vector as "cohomology" will be a self-explanatory
 abuse of notation. We could return some object which prints as `CC^n` and
 has a `dim()` method, but I think thats just a waste of time.

   8. The default should be the most useful value, not the one that isn't
 going to be implemented in the near future ;-)  I implemented the rational
 divisor class group as the parent of the Kahler cone primarily, and I
 think that the integral divisor class group is far less useful as a
 separate object.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9337#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to