#9337: Add toric divisors
-------------------------------------------+--------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: algebraic geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: subsequent patch rebasement |
-------------------------------------------+--------------------------------
Comment(by vbraun):
1) You can remove the `ToricDivisor` from the global namespace as well if
you update doctests accordingly. Historically, I only introduced the
`X.divisor()` method later on...
2) Can you leave this one in?
{{{
# I think there are many rings that should not be used as coefficients
# but checking for such cases is impractical, so I'll comment this...
# if isinstance(R,CohomologyRing):
# raise TypeError, 'Coefficient ring cannot be a cohomology ring.'
}}}
The point of specifically excluding divisors over coordinate rings is that
when you write `(divisor)*(cohomology class)` you want
`divisor.cohomology_class() * (cohomology class)`, so we have to forbid
the undesirable coercion to the divisor ring over the cohomology class.
3) Closing `>` in
{{{
Construct a :class:`(toric Weil) divisor <ToricDivisor_generic` on the
}}}
Rest looks good. I can rebase the next patches after you update the
reviewer patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9337#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
