#9337: Add toric divisors
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-4.6
Component: algebraic geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by novoselt):
1. I did not suggest implementing open cones! Too much work and I don't
see any need for them so far. Only changing the name to something like
`Kaehler_cone_closure` for clarity. And the more I think about it, the
more it seems like a good idea...
3. I know! Maybe that's your influence ;-) But my point is not that
`cohomology` is short, but that it returns a value which is not
cohomology, even if that's the peace of information you want to know about
it. So I still want to rename the current function to `h_vector` and add
just `h` to access degree pieces.
8. Would it be OK to have the following?
{{{
def class_group(base_ring=ZZ):
if base_ring == ZZ:
raise NotImplementedError("only rational class group is
implemented at the moment "
"please use `class_group(QQ)`!")
...
}}}
Meanwhile I will:
* remove `More_vectors`;
* remove `_fan` attribute for divisors. My concern (perhaps, unnecessary)
is that with two different ways to access them people may wonder what's
the difference between `self._fan` and `self.scheme().fan()`;
* implement 5,6,7 (although I agree with your arguments that divisor
classes are not speed-sensitive).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9337#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
