#9400: modify the NumberField constructor to pass in optional integer B such
that
all the internal pari routines will replace the discriminant by its gcd
with B, making some things massively faster.
---------------------------------------------+------------------------------
Reporter: was | Owner: jdemeyer
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6
Component: number fields | Keywords: PARI number field
Author: William Stein, Jeroen Demeyer | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------------------------+------------------------------
Comment(by cremona):
Since this ismarked "needs review" could the authors clarify which patches
are up for review? I assume it is
{{{
9400_maximize_at_primes.patch
Patch for the "maximize at primes" part, rebased to sage-4.6.prealpha1
(see #9343)
}}}
and
{{{
9400_jd_review.patch
Apply on top of 9400_maximize_at_primes.patch
}}}
and not the first one.
Secondly, since these patches have been merged into 4.6.prealpha3 which I
have successfully built and tested, I reckon that the only (!) remaining
task as a reviewer is to look at the code in the patch, with the
additional explanations on the ticket, and approve (or otherwise, maybe)
of it?
I will try to do this before I go away on Friday for a week. No
promises...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9400#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
