#9400: modify the NumberField constructor to pass in optional integer B such
that
all the internal pari routines will replace the discriminant by its gcd
with B, making some things massively faster.
-----------------------------------------------------------+----------------
Reporter: was | Owner:
jdemeyer
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-4.6
Component: number fields | Keywords: PARI
number field
Author: William Stein, Jeroen Demeyer | Upstream: N/A
Reviewer: Jeroen Demeyer, William Stein, John Cremona | Merged:
Work_issues: |
-----------------------------------------------------------+----------------
Changes (by cremona):
* status: needs_review => needs_work
* reviewer: => Jeroen Demeyer, William Stein, John Cremona
Comment:
Looking at the 2nd and 3rd patches (separately) it looks very good to me.
For the benefit of others reading this, the essence of these patches
(apart from some ReSTification) is to expose some additional functionality
from the pari library to Sage, so that some computations can be mande very
much faster (a *lot* faster!).
I spotted a few minor issues in docstrings (numbers refer to the ones I
see in the third patch):
6451: second 'it' --> 'the'
6466: should have a preceding #, or replace ":" by "::" and insert a blank
line after and change the preceding "TESTS::" to "TESTS:"
6592: change "TESTS::" to "TESTS:"
and also when I rebuilt the docs after "sage -ba" (using 4.6.prealpha3) I
got these ReST warnings:
{{{
docstring of sage.libs.pari.gen:136: (WARNING/2) Literal block expected;
none found.
}}}
{{{
docstring of sage.libs.pari.gen.gen.nfbasis:8: (WARNING/2) Definition list
ends without a blank line; unexpected unindent.
}}}
{{{
docstring of sage.libs.pari.gen.gen.nfinit:19: (WARNING/2) Literal block
expected; none found.
}}}
Modulo these, a positive review is on offer. Hence "needs work", but it
is only trivial work.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9400#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
