#8431: Substitutions over unit cube faces (Rauzy fractals)
--------------------------------------------------------------------------------+
Reporter: vdelecroix
| Owner: tjolivet
Type: task
| Status: needs_work
Priority: major
| Milestone: sage-4.6
Component: combinatorics
| Keywords: word morphism unit face generalized substitution rauzy fractal
Author: Vincent Delecroix, Timo Jolivet, Stepan Starosta, Franco Saliola
| Upstream: N/A
Reviewer:
| Merged:
Work_issues:
|
--------------------------------------------------------------------------------+
Changes (by newvalueoldvalue):
* status: needs_review => needs_work
* author: vdelecroix, tjolivet, sstarosta => Vincent Delecroix, Timo
Jolivet, Stepan Starosta, Franco Saliola
Comment:
Cher Timo,
Thanks a lot for your recent effort in polishing that code. I am actually
needing it rigth now!! It will be of great help to me.
I just read through the patch from my web browser and got those comments :
1. As Mike Hanson, I think those three classes should not be in the
global namespace. To create a E1Star, I recommand to add a method in the
`WordMorphism` class.
1. Add the file to the documentation. To do this you must edit the file
sage-your-branch/doc/en/reference/combinat.rst
1. Each sage block must be preceded by ::.
1. No example using color in Face `__init__` function.
1. Examples of all the possible drawings.
1. Rename `_image_by_substitution` to `_apply_substitution` in Face
class.
1. Face._image_by_substitution should only accept E1Star object. If not,
it should raise an `TypeError` and not try to coerce the input to an
E1Star object.
1. Patch.translate method forgets the color of the faces.
1. Patch.apply_substitution should only accept E1Star object. If not, it
should raise an `TypeError` and not try to coerce the input to an E1Star
object.
1. `_M` and `_inv_M` should become `lazy_attributes`
1. `_inv_M` should be computed from _M
1. For the matrix method of E1Star, should `_inv_M` be the "matrix
associated with self" more than `_M` ?
1. When I used these classes last week, I needed the method `__eq__` for
Patch. Here is my code :
{{{
def __eq__(self, other):
r"""
EXAMPLES::
TODO!!
"""
return (isinstance(other, Patch) and
set(self) == set(other) )
}}}
I am going to download, apply and use the patch real soon...and I guess I
will have more comments...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8431#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
