#8431: Substitutions over unit cube faces (Rauzy fractals)
--------------------------------------------------------------------------------+
Reporter: vdelecroix
| Owner: tjolivet
Type: task
| Status: needs_work
Priority: major
| Milestone: sage-4.6
Component: combinatorics
| Keywords: word morphism unit face generalized substitution rauzy fractal
Author: Vincent Delecroix, Timo Jolivet, Franco Saliola, Stepan Starosta
| Upstream: N/A
Reviewer:
| Merged:
Work_issues:
|
--------------------------------------------------------------------------------+
Changes (by slabbe):
* status: needs_review => needs_work
Comment:
I just uploaded a patch which fixes some syntax stuff but I did a little
bit more than that. More importantly, I :
- moved {{{Face._apply_substitution}}} to the method
{{{E1Star._call_on_face}}} because that is where that code belongs.
- reworked {{{Patch.apply_substitution}}} and moved the code that was
repainting the faces to a method called {{{Patch.repaint}}}
- moved the code of {{{Patch.apply_substitution}}} to
{{{E1Star.__call__}}} because it *was* creating a copy anyway.
{{{Patch.apply_substitution}}} works as before. {{{E1Star.__call__}}}
works twice as fast as before because it doesn't do two copies but only
one.
- added some cached method and lazy attributes in {{{E1Star}}} class
I still see one possible problem before giving a positive review, but
didn't have time enough to test/fix it. The attribute
{{{E1Star._base_iter}}} seems to assume some conditions on the values of
faces types. That they are integer for instance. Haven't tested it.
For the tikz output code, I think the {{{\newcommand}}} in the code is not
compatible with sagetex package. If I am not mistaken, {{{\newcommand}}}
are not possible in an input file.
Timo, now that I uploaded a new patch, you will have to create a new
separate patch that applies over yours and mine if you want to modify
anything.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8431#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
