#8431: Substitutions over unit cube faces (Rauzy fractals)
--------------------------------------------------------------------------------+
Reporter: vdelecroix
| Owner: tjolivet
Type: task
| Status: needs_work
Priority: major
| Milestone: sage-4.6
Component: combinatorics
| Keywords: word morphism unit face generalized substitution rauzy fractal
Author: Vincent Delecroix, Timo Jolivet, Franco Saliola, Stepan Starosta
| Upstream: N/A
Reviewer:
| Merged:
Work_issues:
|
--------------------------------------------------------------------------------+
Comment(by slabbe):
Okay, I just re-uploaded my review patch. The faces type is now considered
as an arbitrary object. It can be any hashable object. Doing this, the
code is more readable (e.g. the method {{{_base_iter}}}) and more
versatile (no such {{{type + 1}}} assuming type is an integer).
In order to do so, I changed the way {{{E1Star._base_iter}}} behave. It
now returns a dict.
And now, the domain alphabet of the substitution used must correspond to
the type of faces. No more '1' -> rank('1') = 0 -> + 1 -> 1 = type of a
face. The type of faces iff domain alphabet. If one wants to use integer
type of faces, he must define a substitution on integers which is possible
using dictionary.
I also moved {{{orig_coords}}} to an attribute of Patch called
{{{face_contour}}}. Code gets cleaner that way also. {{{face_contour}}}
now gets assigned at the creation of a Patch.
I also added {{{#not tested}}} to many plot test so that the time of
testing for that file is decreased from 24s to 7s on my computer. I kept
some plot tested at minimum.
My very last concern about the actual state of the ticket is about the
methods outputting tikz code. I want to make sure that they work well. I
will do more test later (I'm done for the day). The necessity of
{{{\newcommand}}} needs to be studied.
Sorry Timo, I am very serious on the review. But I think it is better and
easier to do changes now than after inclusion in Sage.
Cheers,
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8431#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
