#9960: require SAGE_CHECK to be "yes"
------------------------------+---------------------------------------------
Reporter: jhpalmieri | Owner: was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: user interface | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by jhpalmieri):
Replying to [comment:4 leif]:
> Redirecting the output of {{{sage-env}}} is really bad,
I agree.
> and the test of {{{$?}}} is almost useless, since {{{sage-env}}} is (and
must be) sourced, so it must not {{{exit}}} [some value].
Okay.
> The {{{SAGE_CHECK}}} issue (interpreting everything except "no" as
"yes") is AFAIK a historical relict; some spkgs might still run the test
suite from {{{spkg-install}}} if {{{SAGE_CHECK}}} is set and set to
anything but "no".
I ran "grep" after unpacking all of the spkg's, and found SAGE_CHECK used
in cliquer and mpir. In both cases, it checks whether it's "yes". (In
the case of cliquer, this is done in spkg-install, but there is no spkg-
check. So it does the right thing -- running the test suite once if
SAGE_CHECK is "yes", just not in the right way. In the case of mpir, if
SAGE_CHECK is yes, then the test suite gets run twice, once because of the
main sage-spkg script, and once more in mpir's spkg-install script. I
thought there was a ticket for this, but I can't find it right now.)
> Replacing every occurrence of exit in sage-env by return should work
(then testing $? makes sense); I wonder why Sage is started even if sage-
env failed though. (I think there an exit 1 is missing.)
When do you see Sage starting if sage-env fails?
I'll also take a look at #9644. If I can give that a positive review,
I'll change the patch here to make it depend on #9644. (I may do that
anyway...) As far as changing sage-build to source sage-env, could that
break things? The other changes here are pretty inocuous.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9960#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
