#9960: require SAGE_CHECK to be "yes"
------------------------------+---------------------------------------------
Reporter: jhpalmieri | Owner: was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: user interface | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by drkirkby):
Replying to [comment:14 leif]:
> There are already other tickets around touching at least some of the
patched files, too.
>
> I'd say adding the quotes around {{{SAGE_ROOT}}}, adding the {{{exit
1}}} if sourcing failed, and
I won't argue with the {{{SAGE_ROOT}}}. I don't suppose John will. I've
not looked at the exit, but that sounds sensible.
> perhaps replacing {{{exit}}} by {{{return}}} in {{{sage-env}}} should be
mandatory.
It adds extra risk.
> If we always postpone fixes, we'll never get far (and if one opens a new
ticket for every "minor" thing at all, we'll most probably just increase
the number of open tickets, with lots of rebasing being necessary if some
of them finally get merged).
>
> Just my 2 cents.
You will just frustrate people if you expect them to make many changes to
fix a minor issue. Tickets will get left. John has kindly picked up on
something that's not hurting his work, but he knows is wrong. Make it too
difficult, and people will in general just give up and not bother with
such tickets any more.
There's nothing wrong with having a cleanup ticket, where you can make all
the changes you want - for example the Cliquer one #9870.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9960#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
