#9960: require SAGE_CHECK to be "yes"
------------------------------+---------------------------------------------
Reporter: jhpalmieri | Owner: was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: user interface | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by leif):
Replacing {{{exit}}} by {{{return}}} adds no risk if we '''do''' exit when
{{{$? -ne 0}}}.
Note that John's initial patch also did more than necessary for the ticket
(or announced by its title).
So IMHO one should either do just what's necessary to address a specific
issue (and not touch other files), or do "the whole", i.e. fix most of the
open issues with the files you touch, at least the "trivial" ones that do
not require extraordinary testing (e.g. on all platforms).
There's e.g. still
{{{
#!sh
cd "$SAGE_ROOT/devel/sage/sage"
echo "*** TOUCHING ALL CYTHON (.pyx) FILES ***"
touch */*.pyx */*/*.pyx */*/*/*.pyx */*/*/*/*.pyx */*/*/*/*/*.pyx
*/*/*/*/*/*.pyx */*/*/*/*/*/*.
pyx 2> /dev/null
}}}
in {{{sage-build}}}, too. (Count the asterisks!)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9960#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
