#9960: require SAGE_CHECK to be "yes"
------------------------------+---------------------------------------------
Reporter: jhpalmieri | Owner: was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: user interface | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by drkirkby):
Replying to [comment:8 jhpalmieri]:
> I'll also take a look at #9644. If I can give that a positive review,
I'll change the patch here to make it depend on #9644. (I may do that
anyway...) As far as changing sage-build to source sage-env, could that
break things? The other changes here are pretty inocuous.
I agree.
John's changes are safe - the others may be desirable, but introduce extra
risk. It would be a shame if this change got bounced out because larger
changes were added to the ticket. Leif can always create another ticket to
fix the other issues.
I'm keen we improve the code in Sage, but I don't think making lots of
changes to a package every time someone wants to make a minor change, is a
good idea. Leif knows I was pulling my hair out when all I wanted to do
was get iconv to build on HP-UX on #9603.
One point John, if you do change this patch, there's no need to quote
xyes. Since you are absolutely 100% sure that the string xyes has no
spaces in it, there's no need to quote it. It's different for a variable
like $FOOBAR, where you don't know if it might have a space or not.
To my knowledge there's nothing in Sage which checks if SAGE64 is "no".
The only value actually tested for is "yes", so it's a bit pointless
permitting "no".
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9960#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
