#9434: Stop greping for a non-existent sage-banner
------------------------+---------------------------------------------------
   Reporter:  drkirkby  |       Owner:  drkirkby    
       Type:  defect    |      Status:  needs_review
   Priority:  minor     |   Milestone:  sage-5.0    
  Component:  build     |    Keywords:              
     Author:            |    Upstream:  N/A         
   Reviewer:            |      Merged:              
Work_issues:            |  
------------------------+---------------------------------------------------

Comment(by jhpalmieri):

 Replying to [comment:11 leif]:
 > Hmmm, besides I don't like the date format string (which is ''local''
 time), I don't think {{{$SAGE_RELEASE_DATE}}} is available (i.e. set) in
 {{{sage-upgrade}}}.
 >
 > Do you intentionally export {{{OLD_VERSION}}}?

 Right, I'll fix these.

 > A non-existing {{{$SAGE_ROOT/VERSION.txt}}} could be handled as well.
 >
 > I'd prefer having ''"Sage version: ... [Last] Upgraded from: ..."'' on a
 single line (at least in the log).

 Note that the Sage version doesn't appear in the log: it should only
 appear in the files in spkg/installed/.  But maybe a single line is
 cleaner.

 > And we'd have to make sure the version file doesn't get overwritten
 later once we have the root repo.

 We can add VERSION.txt to .hgignore; I think that should do it.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9434#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to