#9434: Stop greping for a non-existent sage-banner
------------------------+---------------------------------------------------
Reporter: drkirkby | Owner: drkirkby
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.6
Component: build | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Comment(by leif):
I wouldn't call {{{sage}}} in {{{sage-upgrade}}}. Also, {{{sage-spkg}}} is
run before {{{sage-upgrade}}} updates {{{VERSION.txt}}}, so (just) the old
version would be logged. (I consider the files in {{{spkg/installed/}}}
also logs, though they have no {{{.log}}} extension.)
Rather than omitting {{{VERSION.txt}}} from the {{{sage_scripts}}} spkg, I
would put the code to update (or better: not overwrite) an existing
{{{VERSION.txt}}} in its {{{spkg-install}}}.
As noted, the version file should be updated ''before'' {{{spkg/install}}}
is called (and that's also before a new scripts spkg gets installed).
We'd have to extract the new version from some newly downloaded file.
(This only works for later Sage versions anyway, unless we handle it in
{{{spkg/install}}}, too.)
----
''"While you're at it"''^TM^, would you mind quoting more instances of
{{{$SAGE_ROOT}}} etc.?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9434#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
