#7931: Improved nth root for finite fields and integer_mods
-------------------------------+--------------------------------------------
   Reporter:  roed             |       Owner:  roed                   
       Type:  enhancement      |      Status:  needs_work             
   Priority:  major            |   Milestone:  sage-4.6               
  Component:  algebra          |    Keywords:  finite fields, nth root
     Author:  David Roe        |    Upstream:  N/A                    
   Reviewer:  Paul Zimmermann  |      Merged:                         
Work_issues:                   |  
-------------------------------+--------------------------------------------
Changes (by zimmerma):

  * status:  needs_review => needs_work


Comment:

 Replying to [comment:29 roed]:
 > You've found a bug in crt: it claims to work as long as the moduli are
 relatively prime, but in fact would often fail if one of them was 1.  I
 fixed that and clarified the behavior of `nth_root` when `n<=0` (it either
 returns the empty list or raises a `ValueError`, depending on the value of
 `all`; `mod(1,n).nth_root(0)` returns the list of all nonzero elements
 modulo n).

 Hi David,

 I'm not very happy with that answer. If a bug in crt was found, I would
 expect you to show a
 concrete example, to report it as a new ticket, and to mention in your 3rd
 patch that it depends
 on the new ticket, and can be removed once the new ticket is fixed.

 Paul

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7931#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to