#7931: Improved nth root for finite fields and integer_mods
-------------------------------+--------------------------------------------
Reporter: roed | Owner: roed
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6
Component: algebra | Keywords: finite fields, nth root
Author: David Roe | Upstream: N/A
Reviewer: Paul Zimmermann | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Changes (by roed):
* status: needs_work => needs_review
Comment:
You're right that it needs doctests; I've added some. I also changed
`7931_fix3.patch` by updating the `nth_root` function in `element_base` to
match the behavior of the one in `integer_mod` for non-positive inputs.
Personally, I don't think that the crt bug is a major enough problem to
need it's own ticket. It only applies if one of the arguments is
mod(0,1). But I've separated the fix into its own patch; if you think it
needs it's own ticket would you be willing to make the ticket and move the
patch over there?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7931#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
