#9664: Graphical representation of fans
----------------------------------+-----------------------------------------
   Reporter:  vbraun              |       Owner:  mhampton    
       Type:  enhancement         |      Status:  needs_review
   Priority:  major               |   Milestone:  sage-4.6    
  Component:  geometry            |    Keywords:              
     Author:  Andrey Novoseltsev  |    Upstream:  N/A         
   Reviewer:  Volker Braun        |      Merged:              
Work_issues:                      |  
----------------------------------+-----------------------------------------

Comment(by novoselt):

 Replying to [comment:8 vbraun]:
 > Its very pretty!

 Thank you ;-)

 > Some thoughts:
 >   * I would be in favor of `wall_color="rainbow"` being the default,
 too.
 Done.
 >   * Maybe lower the threshold where the lattice is no longer shown by
 default; I find `toric_varieties.BCdlOG_base().plot()` already not very
 enlightening.
 Done, now it is radius <= 3 for 3-d plots, I kept 5 for 2-d.
 >   * it would be nice if `toric_variety.plot.__doc__` would have a link
 to `:meth:toric_plotter.options`.
 I am not quite sure what you mean. The plot method of toric varieties does
 have a link to options function, although it was not rendered properly in
 the interactive help - looks like it was because of "NOTE" after
 "EXAMPLES". I have changed the order and now everything looks OK to me.

 I made two more changes: `label_list` now does put an index on a single
 label, if this index was passed by the user. The point is that 2-d cones
 of fans are now marked as "sigma_4" rather than just "sigma". I also use
 `show_lattice=True` as default for `lattice.plot()` independent of the
 size: I was playing with plots of lattices and sublattices and got a bit
 surprised when they have miraculously disappeared.

 > You write "Chamber: 3d cone plotting not implemented yet", did you have
 something particular in mind? A 3D printer? ;-) Seriously, I guess we want
 a `chamber_label` option. Anything else? I also think that, in 3d plots,
 the generating cones and not the 2-cones should be labeled by default. But
 we don't have to implement that right now.

 Didn't think of 3D printers and actually didn't think much about 3-d cones
 until writing the documentation, so it has no reflection in the code yet.
 What I would like to have are "translucent caps" on them, i.e. the piece
 of the bounding sphere that is cut out by the cone. It seems to me that
 the only option is to use polygons in the same way I draw sectors in 3-d
 and it is not completely trivial (but not terribly hard as well). In
 "generators" mode it would be quite easy and natural for CPR-Fanos, but
 again I just didn't work on it yet.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9664#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to