#9433: Put more files under revision control.
------------------------------+---------------------------------------------
   Reporter:  jhpalmieri      |       Owner:  tbd         
       Type:  enhancement     |      Status:  needs_review
   Priority:  major           |   Milestone:  sage-4.6.1  
  Component:  distribution    |    Keywords:              
     Author:  John Palmieri   |    Upstream:  N/A         
   Reviewer:  Leif Leonhardy  |      Merged:              
Work_issues:                  |  
------------------------------+---------------------------------------------

Comment(by jhpalmieri):

 Replying to [comment:64 leif]:
 > We '''have to''' download `spkg/install` (and I'd prefer the rest, too)
 in `sage-update` (the Python script).

 I'm not sure what "the rest" refers to here.

 > What's currently newly made in `sage-upgrade` should be moved to that
 file, which is in any case the fresh, downloaded one. ''There'' we have to
 make a distinction on if we are upgrading.

 Okay, I think I can do that.

 > If so, `spkg/install` should then install the root repo (preferably
 without overwriting itself, but the root repo should, i.e. must, contain
 exactly the same file), since our "real" Makefile `spkg/standard/deps`
 doesn't (though I don't know why you don't want to put the root spkg
 there).

 I don't want to put it there because in a non-upgrade, it's already
 installed as part of the download.

 > Btw, it would be better to also have `sage-spkg` in the root rather than
 the scripts repo; or download an identical copy (from the scripts repo)
 along with `install`, `deps` etc.

 That's not a bad idea, but it should go on another ticket.  What about the
 other scripts in spkg/base, for example sage-env?


 Replying to [comment:65 leif]:
 > Replying to [comment:63 jhpalmieri]:
 > > One issue: if you upgrade a version of Sage containing "makefile",
 then you end up with both "makefile" and "Makefile" when you're done.  We
 can just delete "$SAGE_ROOT/makefile" when running the root-spkg-install
 file.  That's easy enough to do; is it the right solution?
 >
 > Rename it to `Makefile.old`?

 That sounds good to me.

 Replying to [comment:66 leif]:
 > Replying to [comment:62 jhpalmieri]:
 > > I think that if you upgrade from a version with a Sage root repo to
 either of these, you may be asked twice if you want to upgrade.  I
 mentioned this issue
 [http://trac.sagemath.org/sage_trac/ticket/9433#comment:22 above].
 >
 > According to the comment you refer to, this should read ''"upgrade from
 a version '''without''' a Sage root repo"''.

 Yes, that's what I meant to say.  Sorry for any confusion.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9433#comment:67>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to