#10771: gcd and lcm for fraction fields
--------------------------------+-------------------------------------------
Reporter: SimonKing | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7
Component: basic arithmetic | Keywords: gcd lcm fraction fields
Author: Simon King | Upstream: N/A
Reviewer: Marco Streng | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Comment(by SimonKing):
Replying to [comment:29 dsm]:
> Well, even after changing ZZ to QQ there everything seems to work as
expected for me (no segfaults, a quick subset of tests all passed; I'll
try testall long later and look for more crashers), and if it did explode
it sort of feels like it'd be due to a bug somewhere else that it
revealed.. but that can wait for another ticket later.
What came out of the tests?
> The real meat is already in your patch, and I'm already using it, so I'm
very grateful for the work, and hope someone gives the okay soon! `:^)`
You (after finishing the tests, of course)?? Or you could post a patch for
changing `ZZ` to `QQ` in `rings.arith.lcm`, and perhaps I can have a look
on it? If I remember correctly, it is ok if you are reviewer for my patch
and I am reviewer for your patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10771#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
