#10771: gcd and lcm for fraction fields
--------------------------------+-------------------------------------------
Reporter: SimonKing | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7
Component: basic arithmetic | Keywords: gcd lcm fraction fields
Author: Simon King | Upstream: N/A
Reviewer: Marco Streng | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Comment(by kcrisman):
> There is a price to pay, and that's why I put Burcin on Cc:
>
> The distribution of minus signs in symbolic expression changes,
apparently since now gcd raises no errors in examples like the following:
> {{{
> sage: (I - 1/3*sqrt(2))^2
> 1/9*(-sqrt(2) + 3*I)^2
> # Without patch, we would get
> # 1/9*(sqrt(2) - 3*I)^2
> }}}
>
> The question is whether a changed minus sign distribution is such a
serious thing.
What happens with the already existing doctests? That would be what I
would be most concerned about. Also, is the infinite loop now gone? IIRC
you had fixed that somehow.
Really, in some sense the new version is 'better' because it keeps the
minus where the user put it. Do `(-I - 1/3*sqrt(2))^2` and `(I +
1/3*sqrt(2))^2` do anything different from before?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10771#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
