#7377: Symbolic Ring to Maxima via EclObject
-----------------------------------------------------------------------------------+
Reporter: nbruin
| Owner: nbruin
Type: enhancement
| Status: needs_work
Priority: major
| Milestone: sage-feature
Component: symbolics
| Keywords:
Author: Nils Bruin, Jean-Pierre Flori
| Upstream: N/A
Reviewer: Jean-Pierre Flori, François Bissey, Karl-Dieter Crisman, Nils
Bruin | Merged:
Work_issues: loads(dumps()), very minor doctest formatting issues
|
-----------------------------------------------------------------------------------+
Changes (by kcrisman):
* status: needs_review => needs_work
* reviewer: Jean-Pierre Flori, François Bissey, Karl-Dieter Crisman =>
Jean-Pierre Flori, François Bissey, Karl-
Dieter Crisman, Nils Bruin
* work_issues: => loads(dumps()), very minor doctest formatting issues
Comment:
> I was not aware of line length limitation, I'll have a look at that
tonight. For the eqns one, you are right, I just forgot to indent it
correctly.
It's not hard and fast, but it makes it so that when it shows up in a
terminal window it doesn't look weird.
> For the INPUT and OUTPUT blocks, I just tried to follow
http://www.sagemath.org/doc/developer/conventions.html as much as possible
to get something consistent even if it is often redundant or empty.
Maybe we need to add something here about that...
> It is fixed because I changed the check to something else.
Yes, I saw that the fix was the one you suggested earlier - sorry for not
being clear about that.
> The real problem is that this test gives a somewhat random output
according to when it is run.
Well, not too bad. One would expect this, given the nature of the
function.
Okay, so I'll put this to 'needs work' and then hopefully it will be very
easy to produce a p1 of the doctests patch that has the loads/dumps and
fixes the other very minor issues. I can try to review that patch
tomorrow or Wednesday (US East Coast) and run tests.
Can you think of anything that you have done that hasn't been positively
reviewed by Nils or Francois? It's a little hard to determine that from
the comments. At any rate this will be one of the better-tested major
changes in how we interface to a sub-program, thanks to the long gestation
period.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7377#comment:119>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
