#7377: Symbolic Ring to Maxima via EclObject
-----------------------------------------------------------------------------------+
Reporter: nbruin
| Owner: nbruin
Type: enhancement
| Status: needs_work
Priority: major
| Milestone: sage-feature
Component: symbolics
| Keywords:
Author: Nils Bruin, Jean-Pierre Flori
| Upstream: N/A
Reviewer: Jean-Pierre Flori, François Bissey, Karl-Dieter Crisman, Nils
Bruin | Merged:
Work_issues:
|
-----------------------------------------------------------------------------------+
Comment(by kcrisman):
Thanks, JP - I was planning on making the fixes today, but you beat me to
it. They were all oversights of mine, except...
> I uploaded updated versions of both last patches. I accidently deleted
two lines in the previous one which cause the principal error, they are
restored now.
Ah, I wondered if that ecl principal value thing was important.
>I added pickling tests, not sure they make sense.
I don't know if they do either, but this is one of the things Sage has
come to a consensus on, for better or for worse. Some were already there,
as it turned out - in the `__init__`, not class definition - but doesn't
hurt to have the others.
>Also some various fixes and cosmetic changes to reduce line lengths for
sphynx and readibility.
I'll check that all out next, after running my own tests. There is one
final 'evalutation' that I should be able to fix very easily.
>
> Afterwards "make ptestlong" reported no errors on my computer.
>
> Don't know if someone already took a look at what I did to split
Interface class out of Expect class.
I'll try to look at it, but I fear there is a little too much ECL there
for me to feel comfortable reviewing that.
> It seems functional now, but maybe I left some mistakes there.
Maybe Francois can then give positive review :)
I should point out that if this depends on #10743, in principle this
ticket's positive review wouldn't be very useful until that one is
reviewed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7377#comment:124>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
