#11021: clean up sage-spkg
--------------------------+-------------------------------------------------
Reporter: jhpalmieri | Owner: tbd
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.7.1
Component: packages | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Leif Leonhardy
Merged: | Dependencies:
--------------------------+-------------------------------------------------
Comment(by leif):
Well, the code is a bit weird anyway; there should be an `exit 1` if the
package (`$PKG_SRC`) does not exist:
{{{
#!sh
if [ "$INFO" -ne 0 ]; then
if [ ! -f "$PKG_SRC" ]; then
echo "Package $PKG_NAME not found"
# EXIT HERE
fi
...
}}}
I don't think we really need the `echo ""`, since `SPKG.txt` files should
be newline-terminated. (The `tar` commands extract this file to `stdout`.)
----
As far as I know, there are indeed (at least some old, optional) packages
that do have a ''short'' `SAGE.txt` (rather than `SPKG.txt`), so I'm not
sure if we shouldn't check for both.
Also, typical `SPKG.txt` files are quite long, so we might omit some parts
or e.g. "cut" them where the Changelog section starts.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11021#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
