#11021: clean up sage-spkg
--------------------------+-------------------------------------------------
Reporter: jhpalmieri | Owner: tbd
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.7.1
Component: packages | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Kelvin Li | Author: Leif Leonhardy
Merged: | Dependencies:
--------------------------+-------------------------------------------------
Comment(by ltw):
Replying to [comment:9 leif]:
> What about ''"Could not extract SPKG.txt."'' or better ''"Package
$PKG_NAME appears to have no SPKG.txt."''?
I have decided to follow the original phrasing: ''"No file SPKG.txt in
package $PKG_NAME"''.
> Or verify the spkg '''wasn't''' corrupted in case of an error (`$? -ne
0`):
<SNIP>
> But IMHO a rather minor issue.
I didn't touch it for this patch update; I'll have to think about it
later. :-)
> `SPKG.txt` files are supposed to have a quite clear structure, with ReST
(section) mark-up (which an spkg reviewer should check btw). If there's no
line matching `== Changelog ==` -- or preferably a more generic, i.e.
robust pattern, nothing would get omitted.
>
> But as I said, I have no opinion on truncating them there.
Also didn't change anything here. I didn't know that SPKG.txt is supposed
to be structured; honestly I've never even read one. O_o
Replying to [comment:10 leif]:
> P.S.: I wonder if we shouldn't also redirect all warning and error
messages to `stderr` (`echo >2 "..."`). We just recently started doing so
in a couple of other scripts, so it's not yet consistent within Sage, but
an ongoing change.
I have changed a number of these. I wasn't sure on a few cases; please
check them.
I also replaced a few instances of `echo "*************"` with a common
function call (`print_separator`). I'm not sure whether this was a good
idea. Please criticize!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11021#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
