#11246: flint-1.5.0.p5's extraneous #includes break typedef ulong in sys/types.h
-----------------------------------+----------------------------------------
Reporter: dimpase | Owner: tbd
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: packages | Keywords: cygwin
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: Dima Pasechnik
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Comment(by leif):
Finally: ;-)
Replying to [comment:26 kcrisman]:
> Replying to [comment:23 leif]:
> From the "proof-of-concept" spkg (Sphinx):
{{{
#!sh
# Apply patches
cd "$CUR/src"
echo "Patching Sphinx..."
for p in ../patches/*.patch; do
patch -p1 <$p
success "Error applying patch $p"
done
}}}
> > (The `success` function exits `spkg-install` whenever `$? != 0`.)
> This sounds like a great idea on a ''different'' ticket.
> Getting the Cygwin things in is going to be hard enough!
`<scnr><flame>`
Well, I didn't set the ticket to "needs work", though the more I think
about it, the more I'm convinced we shouldn't start(?) accepting code that
literally sets up traps the next ones touching the spkg can easily step
into, with the potential to cause virtually any kind of obscure, hardly
backtraceable error or malfunction.
And perhaps thereby encouraging others in both also omitting checks, and
letting others do so.
Murphy's Law tells us it ''will'' happen, sooner or later... And all
just because someone omitted -- knowingly -- a few simple error checks...
:D
(The "redundant" {{{for j in `ls patches/*.patch`}}} btw has also a nice
side-effect; try it with some patch with spaces in its filename... Ok,
always a bad idea, wasn't it?)
Ok, we can always "fix" it later, on another ticket. Although this
ticket has meanwhile already been postponed to another milestone. And the
changes would be almost trivial.
Procrastination makes things never happen.
`</flame></scnr>`
Sorry, had to let the words flow, get rid of some frustration.
[[BR]]
> Unless you are volunteering to test the rest of them! That would be
very convenient :)
I would if I only could, but I fortunately^TM^ lack suitable Windows
versions to run a recent Cygwin on. ;-)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11246#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
