#11246: flint-1.5.0.p5's extraneous #includes break typedef ulong in sys/types.h
-----------------------------------+----------------------------------------
Reporter: dimpase | Owner: tbd
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: packages | Keywords: cygwin
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: Dima Pasechnik
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Comment(by dimpase):
Replying to [comment:27 leif]:
> Replying to [comment:25 kcrisman]:
> > Replying to [comment:21 leif]:
> > > Replying to [comment:20 dimpase]:
> > > > Replying to [comment:19 kcrisman]:
> > > > > Interestingly, I was just chewed out on another ticket for
having cut some lines in that file down to size! It's true that the new
lines are just a little over that, apparently.
> > >
> > > Of course you shouldn't cut them, but reformat the text such that
none of the lines will exceed 80 characters (same for longer, i.e. all but
the first line of commit messages). ;-)
> >
> > This is exactly what I did, and was rebuked.
>
> Where? By whom? D-:<
>
> No, honestly, if someone refused what others consider a common agreement
this should IMHO be discussed on `sage-devel`.
probably Karl-Dieter means my comment somewhere, which was more in the
spirit of "please do not reformat the files unnecessarily, to decrease
lengths of patches"; I actually wasn't aware of the 80-characters rule...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11246#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
