#11246: flint-1.5.0.p5's extraneous #includes break typedef ulong in sys/types.h
-----------------------------------+----------------------------------------
Reporter: dimpase | Owner: tbd
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: packages | Keywords: cygwin
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: Dima Pasechnik
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Comment(by leif):
Replying to [comment:28 dimpase]:
> probably Karl-Dieter means my comment somewhere, which was more in the
spirit of "please do not reformat the files unnecessarily, to decrease
lengths of patches"; I actually wasn't aware of the 80-characters rule...
The ugly thing with reformatting text is that the diffs usually get hard
to read.
I therefore prefer splitting off such changes from ''code changes'', to be
reviewed separately and independently, since the latter are much more
important.
Nevertheless, both kinds of patches can (and IMHO should) live on the same
ticket, because documentation tends to get neglected.
[[BR]]
Replying to [comment:29 jdemeyer]:
> - Lines in `SPKG.txt` and commit messages should not be too long. There
is no hard 80 characters limit but more of a subjective "not too long"
limit. In practice I would say <= 120 characters is safe.
I would agree in the case of source code (which you read with your
favourite editor), but not documentation that's often just dumped to a
terminal (`sage -info ...`, `hg log -v`, or simply `sage: function?`).
Of course one can usually resize the terminal window (perhaps at the
expense of redoing the command), but that's quite inconvenient, and
there's a reason e.g. newspapers -- and even a lot of blogs -- are typeset
as they are: in multiple, rather narrow columns.
Code is somewhat different, also depending on the language and coding
style.
[[BR]]
> - It is '''not''' needed anymore to add ticket numbers to commit
messages (this used to be the case but this was changed in
sage-4.7.alpha5)
Ooops, there's not just a ''technical'' reason for doing so. That's why I
insist on having them in spkg commit messages as well (alternatively, or
in addition, the full spkg version).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11246#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
