#11246: flint-1.5.0.p5's extraneous #includes break typedef ulong in sys/types.h
---------------------------------------------------+------------------------
Reporter: dimpase | Owner: tbd
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-4.7.2
Component: packages | Keywords: cygwin
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman, Leif Leonhardy | Author: Dima
Pasechnik, Jeroen Demeyer
Merged: | Dependencies:
---------------------------------------------------+------------------------
Comment(by jdemeyer):
Replying to [comment:48 leif]:
> Replying to [comment:46 jdemeyer]:
> > Replying to [comment:38 leif]:
> > > and commit the changes
> > This is no longer necessary, the changes will be committed when the
spkg is merged.
>
> what will be the commit message?
The commit message will be the complete `SPKG.txt` entry, so in this case:
{{{
=== flint-1.5.0.p7 (Jeroen Demeyer, 6 July 2011) ===
* Trac #11246: remove check for gcc version since we require gcc >= 4.0.1
for Sage anyway.
* Use `patch` instead of `cp` for patching the makefile
* Remove test_gcc_version.sh and the horrible makepatchfiles
* Check that `patch` succeeded in spkg-install, apply patches at -p1
level
* Remove obsolete dist/debian directory
}}}
> Then having the last change uncommitted would be a bit inconsistent.
Well, you can always commit all changes yourself, there is no harm. I
personally prefer not to commit any changes until the spkg is really ready
to be shipped.
> Also, I think `sage -pkg ...` would at least currently reject an spkg
with uncommitted changes, which isn't all bad.
It does not reject it, it merely notifies the user that there are
uncomitted changes.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11246#comment:50>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
