#11246: flint-1.5.0.p5's extraneous #includes break typedef ulong in sys/types.h
---------------------------------------------------+------------------------
   Reporter:  dimpase                              |          Owner:  tbd       
                    
       Type:  defect                               |         Status:  
needs_review                  
   Priority:  major                                |      Milestone:  
sage-4.7.2                    
  Component:  packages                             |       Keywords:  cygwin    
                    
Work_issues:                                       |       Upstream:  N/A       
                    
   Reviewer:  Karl-Dieter Crisman, Leif Leonhardy  |         Author:  Dima 
Pasechnik, Jeroen Demeyer
     Merged:                                       |   Dependencies:            
                    
---------------------------------------------------+------------------------

Comment(by leif):

 Replying to [comment:50 jdemeyer]:
 > Well, you can always commit all changes yourself, there is no harm.  I
 personally prefer not to commit any changes until the spkg is really ready
 to be shipped.

 Well, as I said, I just wouldn't encourage others to proceed like that.

 (I know it might sometimes be tedious to undo some changes, but any spkgs
 advertised on a ticket should IMHO have already all changes committed, at
 least if it's "needs review". And having multiple, independent patches to
 an spkg on the ticket for review can be advantageous.)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11246#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to