#11246: flint-1.5.0.p5's extraneous #includes break typedef ulong in sys/types.h
---------------------------------------------------+------------------------
   Reporter:  dimpase                              |          Owner:  tbd       
                    
       Type:  defect                               |         Status:  
positive_review               
   Priority:  major                                |      Milestone:  
sage-4.7.2                    
  Component:  packages                             |       Keywords:  cygwin    
                    
Work_issues:                                       |       Upstream:  N/A       
                    
   Reviewer:  Karl-Dieter Crisman, Leif Leonhardy  |         Author:  Dima 
Pasechnik, Jeroen Demeyer
     Merged:                                       |   Dependencies:            
                    
---------------------------------------------------+------------------------

Comment(by kcrisman):

 Replying to [comment:51 leif]:
 > Except for not having committed the changes (1 rubber point deduction),
 '''positive review''' from me.
 >
 > As I mentioned, I'll make further changes on a follow-up for FLINT
 1.5.2.
 Can you take into account the (very minor) change for #11547 in that?
 The only substantive change is
 {{{
 if [ $UNAME = "CYGWIN" ]; then
     <snip>
    CP -p libflint.so libflint.dll
 }}}
 And this is necessary for Sage to start on Cygwin.  I currently had that
 be p7, but that could be made p8 instead.  I guess the point is that we
 would want this in any further FLINT upgrade, so that we don't have to
 keep making new spkgs.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11246#comment:57>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to