#11598: Congruence testing for odd modular subgroups
---------------------------------+------------------------------------------
Reporter: davidloeffler | Owner: craigcitro
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: modular forms | Keywords: modular congruence subgroup
Work_issues: | Upstream: N/A
Reviewer: Vincent Delecroix | Author: David Loeffler
Merged: | Dependencies: #11422
---------------------------------+------------------------------------------
Comment(by vdelecroix):
Replying to [comment:5 davidloeffler]:
Very nice!
> - implements enumeration of the index 2 odd subgroups of an even
subgroup;
- I modified details of your implementation (not the algorithm). There are
some redundancy, but the code is by far much faster.
- I added a method one_odd_subgroup which is a copy of the first lines of
your function and a randomization of the end. The randomization is
optional (see in the "reviewer" patch).
- With the above function, I added a random_odd_subgroup in the testing
file and make tests compatible with odd subgroups.
> There are probably far better ways of doing the congruence test, as you
suggest; but I'd rather get something that works in quickly, rather than
having to release a Sage version that uses a different definition and then
change it back to the conventional definition later.
I definitely agree.
If you are OK, with my changes, you can put the ticket in positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11598#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
