#11598: Congruence testing for odd modular subgroups
---------------------------------+------------------------------------------
Reporter: davidloeffler | Owner: craigcitro
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: modular forms | Keywords: modular congruence subgroup
Work_issues: | Upstream: N/A
Reviewer: Vincent Delecroix | Author: David Loeffler
Merged: | Dependencies: #11422
---------------------------------+------------------------------------------
Comment(by davidloeffler):
I'm not totally sold on the new version of the random doctest either,
since it has a positive probability of failing! We can't have that, I'm
afraid.
I'm about to upload a new patch. This incorporates all the changes from
both my previous patch and yours, together with some more tiny changes:
I've cleaned up the docstrings slightly, added a few more doctests (mostly
to illustrate how things fail on invalid inputs), and rearranged the order
of the validity checks in the constructor function slightly (mainly for
code clarity, but also giving a tiny efficiency gain by doing the most
expensive test last).
Let me know if you're happy with this version. I'm off to a conference
tomorrow morning, so hopefully this will be the last iteration. Thanks for
your patience with all this reviewing!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11598#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
