#11598: Congruence testing for odd modular subgroups
---------------------------------+------------------------------------------
Reporter: davidloeffler | Owner: craigcitro
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.7.2
Component: modular forms | Keywords: modular congruence subgroup
Work_issues: docstrings | Upstream: N/A
Reviewer: Vincent Delecroix | Author: David Loeffler
Merged: | Dependencies: #11422
---------------------------------+------------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
* work_issues: => docstrings
Comment:
Replying to [comment:10 davidloeffler]:
I'm perfectly ok with your changes in the code.
> I'm not totally sold on the new version of the random doctest either,
since it has a positive probability of failing! We can't have that, I'm
afraid.
Actually, it doesn't. Sage reinitialize the random seed with the same
value before performing the tests. It is safe, but perhaps not pedagogic,
to let it in the doctest. I vote for letting the current version.
Since you made some changes in the documentation. I quickly reread it and
there are some misprints.
- some docstrings start with "Returns bla bla..." and others with "Return
bla bla...". It seems that the Developer guide recommands "Returns".
- The first line of the file starts with "[...] described by the action of
the generators of G ". The generators of the group are not attached to G.
It would be better to set "some generators of G".
- At the begining of the file "Three couples which which [...]"
- since the file tests is not compiled in the reference manual, the link
to the tests module does not appear. So it is not necessary to use the
format :mod:`...`.
- I discussed with some people and the pair of generators which is
involved in continued fractions is (l,s2) and not (l,r). Anyway, (l,r) is
a nice pair because they generate the semi-group of matrix in SL(2,Z) with
non-negative entries.
- In the class ArithmeticSubgroup_Permutation_class, the list of
generators does not appear as they should. There is a bug with the latex
interpretor. If you write "`s_2`, `s_3`, `l`, `r`" then only s_2 is
considered for latex compilation.
That's all.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11598#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
