#11021: Fix "sage -info" and a bug when sourcing sage-env more than once
--------------------------------------------------------+-------------------
Reporter: jhpalmieri | Owner: leif
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-4.7.1
Component: packages | Keywords:
SPKG.txt SAGE.txt -info BUILD sage-env sage-sage sage-spkg
Work_issues: | Upstream: N/A
Reviewer: Kelvin Li, Leif Leonhardy, John Palmieri | Author: Leif
Leonhardy, Kelvin Li
Merged: | Dependencies:
--------------------------------------------------------+-------------------
Comment(by leif):
Replying to [comment:43 jhpalmieri]:
> Re lines 236-243 (and I would guess a similar block in lines 308-314):
{{{
PKG_NAME=`sage-latest-online-package "$PKG_NAME"`
if [ $? -eq 0 ]; then
echo "Found package '$PKG_NAME'."
FOUND_VERSION='1'
else
echo >&2 "$PKG_NAME" # That's now an error message.
exit 1
fi
}}}
> In the "else" part of this, `$PKG_NAME` will likely be an empty string,
so the echo won't print anything. The script `sage-latest-online-package`
prints a suitable error message so this is not a big deal, but it's kind
of odd.
Hmmm, shame on me. I was pretty sure `sage-latest-online-package` would
print the error message to '''`stdout`''' (rather than `stderr`) since
otherwise these two instances of `echo $PKG_NAME` really wouldn't make
sense, so I just added an according comment -- without looking at the
script. 8/
We can either just remove the `echo ...` or add `2>&1` to the command
substitution.
------
> Regarding the comments about Atlas and spkg-check, in retrospect, I'm
not sure I understand what you're saying. If spkg-check fails, then it
makes sense for atlas not to be installed, in which case you don't have a
complete Sage install, in which case I don't mind if a doctest fails. But
as I said, I may be misunderstanding your point.
Forget about that. I just wasn't sure whether ATLAS's `spkg-check` is
"Cygwin-hard" at the moment. If it is not, the build might fail. At least
without `SAGE_CHECK=yes`, `spkg/installed/atlas-*` should (currently^TM^)
always be there, no matter if ATLAS really got (re)installed or not.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11021#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
