#11900: Serious regression caused by #9138
-----------------------------------------------------------------------------------------------+
Reporter: SimonKing
| Owner: tbd
Type: defect
| Status: needs_work
Priority: major
| Milestone: sage-4.7.3
Component: performance
| Keywords: categories regression
Work_issues: fiy doctests, fix categories for polynomial rings, improve
all_super_categories | Upstream: N/A
Reviewer:
| Author: Simon King
Merged:
| Dependencies: #9138
-----------------------------------------------------------------------------------------------+
Changes (by SimonKing):
* work_issues: fiy doctests, fix categories for polynomial rings => fiy
doctests, fix categories for polynomial
rings, improve all_super_categories
Comment:
Replying to [comment:42 SimonKing]:
> In the doc of `sage.categories.category.Category.all_super_categories`,
there is stated:
> {{{
> FIXME:
>
> - make sure that this is compatible with the python algorithm
> for method resolution and make it O(n+m)
> }}}
>
> I think that would be an excellent idea, because the category hierarchy
(determined by `all_super_categories`) and the method resolution order of
the parent classes should be the same.
However, I think that it should be dealt with on a different ticket, since
I don't see how it would help here.
I still see much time spent in `all_super_categories`. I just found that
`self.all_super_categores()` does ''not'' start with
`C.all_super_categories()` for C in `self.super_categories()`. That is
certainly not very efficient, because it is effectively computing
`C.all_supercategories()` repeatedly.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
