#11900: Serious regression caused by #9138
---------------------------+------------------------------------------------
Reporter: SimonKing | Owner: tbd
Type: defect | Status: needs_work
Priority: blocker | Milestone: sage-4.7.2
Component: performance | Keywords: categories regression
Work_issues: | Upstream: N/A
Reviewer: | Author: Simon King
Merged: | Dependencies: #9138
---------------------------+------------------------------------------------
Comment(by SimonKing):
Before I sleep, just a brief report.
It seems to be perfectly alright if one lets parent and element classes
rely on the default pickling of dynamic classes. This alone suffices to
have
{{{
sage: Algebras(GF(3)).parent_class is Algebras(GF(5)).parent_class
True
sage: loads(dumps(Algebras(GF(3)).parent_class)) is
Algebras(GF(5)).parent_class
True
sage: Algebras(GF(3)).parent_class is Algebras(ZZ).parent_class
False
sage: Coalgebras(QQ).parent_class is
Coalgebras(FractionField(QQ[x])).parent_class
True
}}}
The latter was mentioned as "todo" in category.py
And:
{{{
sage: %time L = EllipticCurve('960d1').prove_BSD()
CPU times: user 3.85 s, sys: 0.08 s, total: 3.93 s
Wall time: 4.08 s
}}}
In other words, the regression for `prove_BSD` disappears!
I certainly need to add some doc tests for the new feature, and also it
will probably be needed to fix old tests. But I am confident that I can
post a new patch tomorrow, that may be enough to fix the regression
completely.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
